Skip to content

HDDS-15621. TestSecureOzoneCluster fails locally#10550

Merged
adoroszlai merged 2 commits into
apache:masterfrom
adoroszlai:HDDS-15621
Jun 20, 2026
Merged

HDDS-15621. TestSecureOzoneCluster fails locally#10550
adoroszlai merged 2 commits into
apache:masterfrom
adoroszlai:HDDS-15621

Conversation

@adoroszlai

@adoroszlai adoroszlai commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

TestSecureOzoneCluster fails locally (also reproducible in flaky-test-check):

Expecting actual:
  "scm-sub@localhost"
to contain:
  "<hostname>" 
	at org.apache.hadoop.ozone.TestSecureOzoneCluster.validateCertificate(TestSecureOzoneCluster.java:1360)
	at org.apache.hadoop.ozone.TestSecureOzoneCluster.testSecureOmReInit(TestSecureOzoneCluster.java:883)

because SCM is configured to localhost:

ozone/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestSecureOzoneCluster.java

Line 213 in f9552d0

conf.set(OZONE_SCM_CLIENT_ADDRESS_KEY, "localhost");

but the test expects the actual hostname in certificate issuer name.

Also improve assertions by replacing assertTrue with assertThat.

https://issues.apache.org/jira/browse/HDDS-15621

How was this patch tested?

$ mvn -am -pl :ozone-integration-test -Dtest='TestSecureOzoneCluster' -DskipRecon clean test
...
Tests run: 16, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 232.2 s -- in org.apache.hadoop.ozone.TestSecureOzoneCluster
...

@adoroszlai adoroszlai requested review from ChenSammi and fapifta June 19, 2026 12:49
@adoroszlai adoroszlai self-assigned this Jun 19, 2026
chungen0126
chungen0126 approved these changes Jun 19, 2026
View reviewed changes

@chungen0126 chungen0126 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good to me. Just a nit.

Comment thread hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestSecureOzoneCluster.java
slfan1989
slfan1989 approved these changes Jun 20, 2026
View reviewed changes

@slfan1989 slfan1989 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@adoroszlai adoroszlai merged commit 0322210 into apache:master Jun 20, 2026
31 of 32 checks passed
@adoroszlai

adoroszlai commented Jun 20, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @chungen0126, @slfan1989 for the review.

@adoroszlai adoroszlai deleted the HDDS-15621 branch June 20, 2026 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chungen0126 chungen0126 chungen0126 approved these changes

@fapifta fapifta Awaiting requested review from fapifta

@ChenSammi ChenSammi Awaiting requested review from ChenSammi

+1 more reviewer

@slfan1989 slfan1989 slfan1989 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@adoroszlai adoroszlai

Labels

test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adoroszlai @slfan1989 @chungen0126